READY FOR REVIEW

Summary

• Fixed people teaser cards to correct size and shape.
• Fixed Person Node image to correct size and shape

Review By (Date)

• 11/22

Criticality

• High

Urgency

• High

Review Tasks

Setup tasks and/or behavior to test

1. Check out this gitpod
2. Create some people (just clone and publish)
3. Navigate to /person page and verify image looks correct
4. Create a list of teasers and verify it works.
5. Navigate to a person page and verify no longer a circle and bigger in size.

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory?

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

- D8CORE-7659

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials